Skip to content

Commit

Permalink
Improved doxygen (#389)
Browse files Browse the repository at this point in the history
Signed-off-by: ahcorde <ahcorde@gmail.com>
  • Loading branch information
ahcorde authored Aug 30, 2021
1 parent 99c08c5 commit 08ee26c
Show file tree
Hide file tree
Showing 40 changed files with 214 additions and 174 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
uses: ignition-tooling/action-ignition-ci@bionic
with:
codecov-enabled: true
doxygen-enabled: true
focal-ci:
runs-on: ubuntu-latest
name: Ubuntu Focal CI
Expand Down
4 changes: 2 additions & 2 deletions include/ignition/rendering/Camera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ namespace ignition
public: virtual math::Angle HFOV() const = 0;

/// \brief Set the camera's horizontal field-of-view
/// \param[in] _angle Desired horizontal field-of-view
public: virtual void SetHFOV(const math::Angle &_angle) = 0;
/// \param[in] _hfov Desired horizontal field-of-view
public: virtual void SetHFOV(const math::Angle &_hfov) = 0;

/// \brief Get the camera's aspect ratio
/// \return The camera's aspect ratio
Expand Down
2 changes: 1 addition & 1 deletion include/ignition/rendering/GaussianNoisePass.hh
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ namespace ignition
public: virtual void SetMean(double _mean) = 0;

/// \brief Set stddev.
/// \param[in] _stddev Standard deviation of Gaussian noise.
/// \param[in] _stdDev Standard deviation of Gaussian noise.
public: virtual void SetStdDev(double _stdDev) = 0;

/// \brief Set the mean of the bias value. Bias is computed based on
Expand Down
4 changes: 2 additions & 2 deletions include/ignition/rendering/Geometry.hh
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ namespace ignition
/// \param[in] _name Name of registered Material
/// \param[in] _unique True if the specified material should be cloned
public: virtual void SetMaterial(const std::string &_name,
bool unique = true) = 0;
bool _unique = true) = 0;

/// \brief Set the materials of this Geometry
/// \param[in] _material New Material to be assigned
/// \param[in] _unique True if the given material should be cloned
public: virtual void SetMaterial(MaterialPtr _material,
bool unique = true) = 0;
bool _unique = true) = 0;

/// \brief Get the material of this geometry
/// \return Material used by this geometry
Expand Down
2 changes: 1 addition & 1 deletion include/ignition/rendering/GpuRays.hh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ namespace ignition
/// \brief Configure behaviour for data values outside of camera range
/// \param[in] _clamp True to clamp data to camera clip distances,
// false to leave data values as +/-inf when out of camera range
public: virtual void SetClamp(const bool _value) = 0;
public: virtual void SetClamp(const bool _clamp) = 0;

/// \brief Get behaviour for data values outside of camera range
/// \return True if data values are clampped to camera clip distances,
Expand Down
6 changes: 3 additions & 3 deletions include/ignition/rendering/Light.hh
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ namespace ignition
public: virtual double AttenuationRange() const = 0;

/// \brief Set the attenuation range
/// \param[in] _value New attenuation range
/// \param[in] _range New attenuation range
public: virtual void SetAttenuationRange(double _range) = 0;

/// \brief Determine if this light cast shadows
Expand Down Expand Up @@ -171,7 +171,7 @@ namespace ignition
public: virtual void SetInnerAngle(double _radians) = 0;

/// \brief Set the inner angle of the spotlight
/// \param[in] _radians New inner angle of the spotlight
/// \param[in] _angle New inner angle of the spotlight
public: virtual void SetInnerAngle(const math::Angle &_angle) = 0;

/// \brief Get the outer angle of the spotlight
Expand All @@ -183,7 +183,7 @@ namespace ignition
public: virtual void SetOuterAngle(double _radians) = 0;

/// \brief Set the outer angle of the spotlight
/// \param[in] _radians New outer angle of the spotlight
/// \param[in] _angle New outer angle of the spotlight
public: virtual void SetOuterAngle(const math::Angle &_angle) = 0;

/// \brief Get the falloff of the spotlight
Expand Down
2 changes: 1 addition & 1 deletion include/ignition/rendering/Marker.hh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ namespace ignition
public: virtual int32_t Layer() const = 0;

/// \brief Set the render type of this Marker
/// \param[in] The desired render type
/// \param[in] _markerType The desired render type
public: virtual void SetType(
const ignition::rendering::MarkerType _markerType) = 0;

Expand Down
28 changes: 16 additions & 12 deletions include/ignition/rendering/Material.hh
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ namespace ignition
public: virtual std::string Texture() const = 0;

/// \brief Set the material texture
/// \param[in] _name URI of the new texture file
public: virtual void SetTexture(const std::string &_name) = 0;
/// \param[in] _texture URI of the new texture file
public: virtual void SetTexture(const std::string &_texture) = 0;

/// \brief Removes any texture mapped to this material
public: virtual void ClearTexture() = 0;
Expand All @@ -216,8 +216,8 @@ namespace ignition
public: virtual std::string NormalMap() const = 0;

/// \brief Set the material normal map
/// \param[in] _name URI of the new normal map file
public: virtual void SetNormalMap(const std::string &_name) = 0;
/// \param[in] _normalMap URI of the new normal map file
public: virtual void SetNormalMap(const std::string &_normalMap) = 0;

/// \brief Removes any normal map mapped to this material
public: virtual void ClearNormalMap() = 0;
Expand All @@ -231,8 +231,9 @@ namespace ignition
public: virtual std::string RoughnessMap() const = 0;

/// \brief Set the material roughness map
/// \param[in] _name URI of the new roughness map file
public: virtual void SetRoughnessMap(const std::string &_name) = 0;
/// \param[in] _roughnessMap URI of the new roughness map file
public: virtual void SetRoughnessMap(
const std::string &_roughnessMap) = 0;

/// \brief Removes any roughness map mapped to this material
public: virtual void ClearRoughnessMap() = 0;
Expand All @@ -246,8 +247,9 @@ namespace ignition
public: virtual std::string MetalnessMap() const = 0;

/// \brief Set the material metalness map
/// \param[in] _name URI of the new metalness map file
public: virtual void SetMetalnessMap(const std::string &_name) = 0;
/// \param[in] _metalnessMap URI of the new metalness map file
public: virtual void SetMetalnessMap(
const std::string &_metalnessMap) = 0;

/// \brief Removes any metalness map mapped to this material
public: virtual void ClearMetalnessMap() = 0;
Expand All @@ -261,8 +263,9 @@ namespace ignition
public: virtual std::string EnvironmentMap() const = 0;

/// \brief Set the material environment map
/// \param[in] _name URI of the new environment map file
public: virtual void SetEnvironmentMap(const std::string &_name) = 0;
/// \param[in] _metalnessMap URI of the new environment map file
public: virtual void SetEnvironmentMap(
const std::string &_metalnessMap) = 0;

/// \brief Removes any environment map mapped to this material
public: virtual void ClearEnvironmentMap() = 0;
Expand All @@ -276,8 +279,9 @@ namespace ignition
public: virtual std::string EmissiveMap() const = 0;

/// \brief Set the material emissive map
/// \param[in] _name URI of the new emissive map file
public: virtual void SetEmissiveMap(const std::string &_name) = 0;
/// \param[in] _emissiveMap URI of the new emissive map file
public: virtual void SetEmissiveMap(
const std::string &_emissiveMap) = 0;

/// \brief Removes any emissive map mapped to this material
public: virtual void ClearEmissiveMap() = 0;
Expand Down
4 changes: 2 additions & 2 deletions include/ignition/rendering/Mesh.hh
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ namespace ignition
/// \param[in] _name Name of registered Material
/// \param[in] _unique True if the specified material should be cloned
public: virtual void SetMaterial(const std::string &_name,
bool unique = true) = 0;
bool _unique = true) = 0;

/// \brief Set the materials of this SubMesh
/// \param[in] _material New Material to be assigned
/// \param[in] _unique True if the given material should be cloned
public: virtual void SetMaterial(MaterialPtr _material,
bool unique = true) = 0;
bool _unique = true) = 0;
};
}
}
Expand Down
5 changes: 2 additions & 3 deletions include/ignition/rendering/RayQuery.hh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ namespace ignition
public: virtual math::Vector3d Origin() const = 0;

/// \brief Set ray direction
/// \param[in] _origin Ray origin
/// \param[in] _dir Ray origin
public: virtual void SetDirection(const math::Vector3d &_dir) = 0;

/// \brief Get ray direction
Expand All @@ -89,8 +89,7 @@ namespace ignition
const math::Vector2d &_coord) = 0;

/// \brief Compute intersections
/// \param[out] A vector of intersection results
/// \return True if results are not empty
/// \return A vector of intersection results
public: virtual RayQueryResult ClosestPoint() = 0;
};
}
Expand Down
2 changes: 1 addition & 1 deletion include/ignition/rendering/RenderEngine.hh
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ namespace ignition
const std::string &_name) = 0;

/// \brief Add path to media resource location
/// \param[in] _paths Absolute path to resource location
/// \param[in] _path Absolute path to resource location
public: virtual void AddResourcePath(const std::string &_path) = 0;

/// \brief Get the render pass system for this engine.
Expand Down
Loading

0 comments on commit 08ee26c

Please sign in to comment.