Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/depth_camera: Fixed windows usage #1060

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 16, 2024

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1494

Summary

This PR allows building and running depth_camera example on Windows.

I'm not sure about the thing with RESOURCE_PATH, but I had to do it on Windows.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <peci1@seznam.cz>
@peci1
Copy link
Contributor Author

peci1 commented Sep 16, 2024

On my Intel iGPU, I'm facing #1059, but that's probably not relevant to this PR.

@iche033 iche033 merged commit 21993f0 into gazebosim:gz-rendering9 Sep 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-rendering: Depth camera
2 participants