Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waves 'double' to 'float' truncation warning #1065

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Crola1702
Copy link
Contributor

🦟 Bug fix

Fixes #osrf/buildfarm-tools#92 (comment)

Summary

Reference builds:

Warning:

Log output:

  waves.cc

C:\J\workspace\gz_rendering-7-win\ws\gz-rendering\test\integration\waves.cc(170,29): warning C4305: 'initializing': truncation from 'double' to 'float' [C:\J\workspace\gz_rendering-7-win\ws\build\gz-rendering7\test\integration\INTEGRATION_waves.vcxproj]

C:\J\workspace\gz_rendering-7-win\ws\gz-rendering\test\integration\waves.cc(174,28): warning C4305: 'initializing': truncation from 'double' to 'float' [C:\J\workspace\gz_rendering-7-win\ws\build\gz-rendering7\test\integration\INTEGRATION_waves.vcxproj]

  waves.obj : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 self-assigned this Sep 16, 2024
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 16, 2024
@iche033 iche033 merged commit bdbae42 into gz-rendering7 Sep 16, 2024
9 of 10 checks passed
@iche033 iche033 deleted the Crola1702/fix-truncation-warning branch September 16, 2024 20:41
Crola1702 added a commit that referenced this pull request Sep 16, 2024
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants