-
Notifications
You must be signed in to change notification settings - Fork 70
Fix/optix warning #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/optix warning #1199
Conversation
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
|
thanks for looking into this. Given that we're not actively working on the optix plugin for gz-rendering and it's also not being tested in our CI, I think it would be best to just silence the warning. |
Signed-off-by: miguelgonrod <miguel.gonzales@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzales@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
|
Ready, i reverted the changes of the dependencies and instead silenced the |
SInce the code is so old now, if anyone wants to add support for Optix at some point, would they build on the existing code or would it be better to start from scratch? |
I'm thinking to deprecate optix plugin and remove this plugin given that we haven't had any time to work on it. Last I ran optix was version 4.x and the latest version is now 9.x (as of Dec 2025). If someone wants to update optix to the latest version, it maybe easier to start from scratch (and they can check out existing code as reference). |
|
Sounds good! I'm in favor of removing it. Since it doesn't work at all, I'd be okay with removing it without going through a deprecation cycle. |
ok I ticketed #1203 to remove the optix plugin |
🦟 Bug fix
Fixes #1198
Summary
Jobs related to https://build.osrfoundation.org/job/gz_rendering-ci-gz-rendering10-noble-amd64/ and https://build.osrfoundation.org/job/gz_rendering-ci-main-noble-amd64 were building with a cmake warning because they need
libfreeimagedependency.I added to
.github/ci/packages.aptfreeglut3-dev + libfreeimage-dev libglew-devAnother approach would be to silence warning, as some time ago was tried in
https://github.com/gazebosim/gz-rendering/pull/1032, but I don't know if is better to silence instead of adding the dependencyChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.