Skip to content

Conversation

@miguelgonrod
Copy link
Contributor

🦟 Bug fix

Fixes #1198

Summary

Jobs related to https://build.osrfoundation.org/job/gz_rendering-ci-gz-rendering10-noble-amd64/ and https://build.osrfoundation.org/job/gz_rendering-ci-main-noble-amd64 were building with a cmake warning because they need libfreeimage dependency.
I added to .github/ci/packages.apt

freeglut3-dev
+ libfreeimage-dev
libglew-dev

Another approach would be to silence warning, as some time ago was tried in https://github.com/gazebosim/gz-rendering/pull/1032, but I don't know if is better to silence instead of adding the dependency

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
Signed-off-by: miguelgonrod <miguelgonrod2004@gmail.com>
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Dec 9, 2025
@miguelgonrod miguelgonrod marked this pull request as ready for review December 9, 2025 22:18
@miguelgonrod miguelgonrod requested a review from iche033 as a code owner December 9, 2025 22:18
@iche033
Copy link
Contributor

iche033 commented Dec 10, 2025

thanks for looking into this. Given that we're not actively working on the optix plugin for gz-rendering and it's also not being tested in our CI, I think it would be best to just silence the warning.

@miguelgonrod miguelgonrod marked this pull request as draft December 11, 2025 18:05
miguelgonrod and others added 3 commits December 11, 2025 13:05
Signed-off-by: miguelgonrod <miguel.gonzales@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzales@ekumenlabs.com>
Signed-off-by: miguelgonrod <miguel.gonzalez@ekumenlabs.com>
@miguelgonrod miguelgonrod marked this pull request as ready for review December 11, 2025 18:42
@miguelgonrod
Copy link
Contributor Author

Ready, i reverted the changes of the dependencies and instead silenced the libfreeimage-dev dependency. cnlwin "failure" are caused by tests, not by this change

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Dec 11, 2025
@azeey
Copy link
Contributor

azeey commented Dec 12, 2025

Given that we're not actively working on the optix plugin for gz-rendering and it's also not being tested in our CI, I think it would be best to just silence the warning.

SInce the code is so old now, if anyone wants to add support for Optix at some point, would they build on the existing code or would it be better to start from scratch?

@iche033
Copy link
Contributor

iche033 commented Dec 13, 2025

Given that we're not actively working on the optix plugin for gz-rendering and it's also not being tested in our CI, I think it would be best to just silence the warning.

SInce the code is so old now, if anyone wants to add support for Optix at some point, would they build on the existing code or would it be better to start from scratch?

I'm thinking to deprecate optix plugin and remove this plugin given that we haven't had any time to work on it. Last I ran optix was version 4.x and the latest version is now 9.x (as of Dec 2025). If someone wants to update optix to the latest version, it maybe easier to start from scratch (and they can check out existing code as reference).

@azeey
Copy link
Contributor

azeey commented Dec 15, 2025

Sounds good! I'm in favor of removing it. Since it doesn't work at all, I'd be okay with removing it without going through a deprecation cycle.

@Crola1702 Crola1702 merged commit 7b3fafd into gazebosim:gz-rendering10 Dec 15, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Dec 15, 2025
@iche033 iche033 mentioned this pull request Dec 15, 2025
@iche033
Copy link
Contributor

iche033 commented Dec 15, 2025

Sounds good! I'm in favor of removing it. Since it doesn't work at all, I'd be okay with removing it without going through a deprecation cycle.

ok I ticketed #1203 to remove the optix plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🧑‍🌾 gz_rendering-ci-main/rendering-10-noble cmake warning related to libfreeimage dependency

4 participants