Fix custom_scene_viewer for macOS #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
reviewed
Feb 24, 2021
There was a problem hiding this comment.
Thanks for the contribution, we'll be trying it out shortly. Meanwhile, do you mind signing your commit to satisfy the DCO check? See our contributing guide.
|
Sure - will do. Thought I'd set that up in SourceTree before committing but must have missed something. Are you ok with a force push on the PR once I get the signing in place? |
Sure, I think there's no way around this. Thanks! |
srmainwaring
force-pushed
the
feature/ir4-custom_scene_viewer
branch
from
cb40031 to
0f82c1f
Compare
|
Force pushed signed commit. |
|
it's still not signed - DCO |
srmainwaring
force-pushed
the
feature/ir4-custom_scene_viewer
branch
from
0f82c1f to
202315b
Compare
1. Add OpenGL context settings for macOS to the DemoWindow. 2. Move glutInit to main 3. Add command line option to set the ogre engine. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
srmainwaring
force-pushed
the
feature/ir4-custom_scene_viewer
branch
from
202315b to
3117c7d
Compare
|
Rebased on upstream ign-rendering4 and signed-off |
7 tasks
iche033
reviewed
Feb 25, 2021
1. Use camel case for variables. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
|
@osrf-jenkins run tests please |
iche033
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
No issue raised but related to #185
Summary
The example
custom_scene_viewerdoes not display a window on macOS. The example will build and run, the console will display the usage, however the GLUT window does not open.Configuration
Detail
The issue was that the OpenGL context was not managed for macOS. The fix is to add the conditional compilation flags and variables used in the
simple_demoand adapt them for this example. It was also necessary to move the glutInit() tomain() as it seems that this is required before the rendering engine is initialised during the scene building.
Tests
Because of issues with a side-by-side install of ogre and ogre2, tests were limited to ogre1.9 only and ogre2 was brew unlinked before compilation of ignition-rendering.
The images show the first four scenes of the demo running on macOS.
Checklist
codecheckpassed (See contributing)