Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 4 ➡️ 5 #258

Merged
merged 9 commits into from
Feb 25, 2021
Merged

👩‍🌾 4 ➡️ 5 #258

merged 9 commits into from
Feb 25, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-rendering4 to main.

Branch comparison: main...ign-rendering4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)


https://github.com/osrf/buildfarmer/issues/161

jennuine and others added 9 commits February 16, 2021 14:56
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
…ose information (#255)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner February 25, 2021 01:41
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #258 (da36782) into main (dcc9fd6) will increase coverage by 0.36%.
The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   57.25%   57.61%   +0.36%     
==========================================
  Files         151      151              
  Lines       15181    15318     +137     
==========================================
+ Hits         8692     8826     +134     
- Misses       6489     6492       +3     
Impacted Files Coverage Δ
ogre2/src/Ogre2Scene.cc 88.70% <ø> (ø)
ogre2/src/Ogre2RenderEngine.cc 78.82% <33.33%> (-0.58%) ⬇️
ogre2/src/Ogre2ParticleEmitter.cc 77.77% <86.00%> (+1.91%) ⬆️
ogre2/src/Ogre2DepthCamera.cc 91.06% <100.00%> (+1.34%) ⬆️
ogre2/src/Ogre2GpuRays.cc 94.75% <100.00%> (+0.51%) ⬆️
ogre2/src/Ogre2ThermalCamera.cc 90.75% <100.00%> (+0.05%) ⬆️
ogre2/src/Ogre2Visual.cc 85.14% <100.00%> (+0.30%) ⬆️
...ude/ignition/rendering/base/BaseParticleEmitter.hh 44.15% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc9fd6...da36782. Read the comment docs.

@chapulina chapulina merged commit af7c67d into main Feb 25, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch February 25, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants