ign-redering working on windows

[ahcorde]

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

This changes allow to run ign-rendering on Windows:

I added some required files in Media, the version that we installed with conda it's 1.12 there are some thing that need to be updated.

I also update:

• simple_demo
• thermal_camera. This demo is partially working, there are some path that are broken due the "" and "/". The duck is not showed.

There are some other things that may require some more changes.

FYI @WilliamLewww @chapulina @mjcarroll @iche033 @j-rivero

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #291 (c09cc13) into ign-rendering5 (e0bf818) will decrease coverage by 0.01%.
The diff coverage is 54.54%.

❗ Current head c09cc13 differs from pull request most recent head 0de3dbc. Consider uploading reports for the commit 0de3dbc to get more accurate results

@@                Coverage Diff                 @@
##           ign-rendering5     #291      +/-   ##
==================================================
- Coverage           57.54%   57.53%   -0.02%     
==================================================
  Files                 159      159              
  Lines               15590    15593       +3     
==================================================
  Hits                 8971     8971              
- Misses               6619     6622       +3     

Impacted Files	Coverage Δ
ogre/src/OgreCamera.cc	0.00% <0.00%> (ø)
src/base/BaseScene.cc	74.95% <0.00%> (-0.13%)	⬇️
ogre/src/OgreRenderEngine.cc	73.79% <100.00%> (+0.07%)	⬆️
ogre2/src/Ogre2Light.cc	98.30% <100.00%> (ø)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	96.66% <0.00%> (-3.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bf818...0de3dbc. Read the comment docs.

[chapulina]

@ahcorde , do you have plans to go back to this PR? Edifice will EOL next week, should this be retargeted at ign-rendering6?

[ahcorde]

I was able to make Windows work with Ogre 1.12 I don't remember, but I think this version is not working properly in Ubuntu (we are using Ogre1.9).

Maybe we should versioned the folder ogre/src/media/ to -> ogre/src/media/1.9 and ogre/src/media/1.12.

I don't' know how does it sound, I can put some time on this if this makes sense at same point the future.

Anyhow we should retarget this to ign-gazebo6

[chapulina]

Maybe we should versioned the folder ogre/src/media/ to -> ogre/src/media/1.9 and ogre/src/media/1.12.

Humm I see. Officially we only support 1.9, and others can use higher minor versions at their own risk. But if this is required for Windows to work we should consider supporting that too. It's not ideal to duplicate the media though.

[azeey]

Ogre now works in windows since #992. I'll go ahead and close this issue since we're no longer working on it.