Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserData methods moved from Visual to Node #358

Merged
merged 6 commits into from
Jul 15, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 2, 2021

🦟 Bug fix

Fixes #58

Summary

This PR is part of the effort to consolidate ign-gui and ign-gazebo (related to this conversation gazebosim/gz-gui#231 (comment)) and it also targets this issue #58.

The idea is to move the UserData and SetUserData methods to the Node class. I'm not sure how to proceed about the change in the API if I should tick-tock the methods in the Visual class, this change should not affect the API because Node is a parent class of Visual, it will break ABI but this PR is targeting main.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
include/ignition/rendering/Node.hh Outdated Show resolved Hide resolved
src/base/BaseScene.cc Outdated Show resolved Hide resolved
include/ignition/rendering/Node.hh Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina July 7, 2021 09:24
Signed-off-by: ahcorde <ahcorde@gmail.com>
@iche033
Copy link
Contributor

iche033 commented Jul 13, 2021

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 14, 2021

@osrf-jenkins retest this please

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 14, 2021

@iche033 Fixed 978b6bc

@iche033
Copy link
Contributor

iche033 commented Jul 14, 2021

#361 should fix the github CI failing builds

@chapulina chapulina enabled auto-merge (squash) July 15, 2021 03:02
@chapulina chapulina merged commit f3f75a5 into main Jul 15, 2021
@chapulina chapulina deleted the ahcorde/node/userdata branch July 15, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants