UserData methods moved from Visual to Node #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #58
Summary
This PR is part of the effort to consolidate
ign-gui
andign-gazebo
(related to this conversation gazebosim/gz-gui#231 (comment)) and it also targets this issue #58.The idea is to move the
UserData
andSetUserData
methods to the Node class. I'm not sure how to proceed about the change in the API if I should tick-tock the methods in the Visual class, this change should not affect the API becauseNode
is a parent class ofVisual
, it will break ABI but this PR is targetingmain
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge