Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed screento functions names #368

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 20, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Related to this comment #363 (comment)

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from iche033 July 20, 2021 21:04
@ahcorde ahcorde self-assigned this Jul 20, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #368 (5d3dfda) into ign-rendering3 (dbbc3d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #368   +/-   ##
===============================================
  Coverage           53.34%   53.35%           
===============================================
  Files                 131      131           
  Lines               12036    12036           
===============================================
+ Hits                 6421     6422    +1     
+ Misses               5615     5614    -1     
Impacted Files Coverage Δ
src/Utils.cc 75.00% <100.00%> (ø)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbbc3d7...5d3dfda. Read the comment docs.

@chapulina chapulina merged commit 9341eb2 into ign-rendering3 Jul 20, 2021
@chapulina chapulina deleted the ahcorde/fix/screeto_name branch July 20, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants