Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output warning message if a mesh with zero submeshes is created #391

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 30, 2021

🦟 Bug fix

Summary

Currently if a ign-gazebo user specifies a non-existent submesh through the <submesh> SDF element, an empty mesh with no submeshes will be created. The newly added warning msg is useful to help catch issues / typos with incorrectly specified submesh name.

To test:

you can change a submesh name in one of the ign-gazebo example worlds to see the warning msg printed in the console, e.g. edit tunnel.sdf and change this submesh from BodyFront to FrontBody then launch the tunnel world.

ign gazebo -v 4 tunnel.sdf

and you should see this warning msg:

[GUI] [Wrn] [Ogre2MeshFactory.cc:478] Unable to load mesh: 'https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/EXPLORER_R2_SENSOR_CONFIG_2/3/files/meshes/r2.dae', submesh: 'FrontBody'. Mesh will be empty.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #391 (b588a4f) into ign-rendering4 (f65f2fa) will decrease coverage by 0.04%.
The diff coverage is 8.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering4     #391      +/-   ##
==================================================
- Coverage           55.93%   55.89%   -0.05%     
==================================================
  Files                 147      147              
  Lines               13964    13976      +12     
==================================================
+ Hits                 7811     7812       +1     
- Misses               6153     6164      +11     
Impacted Files Coverage Δ
ogre/src/OgreMeshFactory.cc 1.08% <0.00%> (-0.03%) ⬇️
ogre2/src/Ogre2MeshFactory.cc 81.88% <16.66%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65f2fa...b588a4f. Read the comment docs.

@iche033 iche033 merged commit 622a7ba into ign-rendering4 Aug 31, 2021
@iche033 iche033 deleted the submesh_warn branch August 31, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants