-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone visuals and geometries #397
Conversation
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iche033 I've got a few comments/questions for you when you get the chance to take a look at this
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 55.05% 55.18% +0.13%
==========================================
Files 191 191
Lines 19265 19348 +83
==========================================
+ Hits 10607 10678 +71
- Misses 8658 8670 +12
Continue to review full report at Codecov.
|
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
9d87388
to
200be22
Compare
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
I made some minor tweaks in #418. Can you take a look? |
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me.
will merge on green CI
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ashton Larkin ashton@openrobotics.org
🎉 New feature
Summary
I've added support for cloning visuals and geometries.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge