Find IgnOGRE once, then warn if version is too new

[sloretz]

🦟 Bug fix

Fixes #400

Summary

Note: I have not tested this locally.

This is an idea to fix #400. I would expect it to get rid of the CMake warning about missing Ogre when the installed version is 1.9.0. It doesn't look like Ignition CMake ore Ignition Rendering pass the EXACT argument to the real find_package() call for either IgnOGRE or OGRE. Because of that, the compatibility is up to OGRE, and it uses SameMajorVersion compatibility. That means ign_find_package(IgnOGRE VERSION 1.9.0 ...) should find OGRE 1.x where x >= 9. This PR checks OGRE_VERSION after finding IgnOGRE, and only then warns if it is newer than the supported version.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[codecov]

Codecov Report

Merging #428 (1cb5b73) into ign-rendering5 (f83dc91) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1cb5b73 differs from pull request most recent head aaa4bf0. Consider uploading reports for the commit aaa4bf0 to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering5     #428   +/-   ##
===============================================
  Coverage           57.77%   57.77%           
===============================================
  Files                 161      161           
  Lines               15947    15947           
===============================================
+ Hits                 9213     9214    +1     
+ Misses               6734     6733    -1     

Impacted Files	Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	100.00% <0.00%> (+3.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83dc91...aaa4bf0. Read the comment docs.

[sloretz]

CMake Warning appears to be fixed in CI

cmake /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/ign-rendering -DSKIP_optix=true -DCMAKE_INSTALL_PREFIX=/usr
-- The C compiler identification is GNU 8.4.0
-- The CXX compiler identification is GNU 8.4.0
-- Check for working C compiler: /usr/lib/ccache/cc
-- Check for working C compiler: /usr/lib/ccache/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/lib/ccache/c++
-- Check for working CXX compiler: /usr/lib/ccache/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- ignition-rendering5 version 5.1.0
-- Operating system is Linux
-- Found CPack generators: DEB
-- Looking for ignition-math6 -- found version 6.8.0
-- Searching for dependencies of ignition-math6
-- Looking for ignition-math6 - found

-- Looking for ignition-common4 -- found version 4.2.0
-- Searching for dependencies of ignition-common4
-- Looking for dlfcn.h - found
-- Looking for libdl - found
-- Found DL: TRUE  
-- Checking for module 'uuid'
--   Found uuid, version 2.31.1
-- Found UUID: TRUE  
-- Searching for <ignition-common4> component [graphics]
-- Looking for ignition-common4-graphics -- found version 4.2.0
-- Searching for dependencies of ignition-common4-graphics
-- Looking for ignition-math6 -- found version 6.8.0
-- Looking for ignition-utils1 -- found version 1.1.0
-- Searching for dependencies of ignition-utils1
-- Searching for <ignition-common4> component [events]
-- Looking for ignition-common4-events -- found version 4.2.0
-- Searching for dependencies of ignition-common4-events
-- Looking for ignition-math6 -- found version 6.8.0
-- Looking for ignition-common4 - found

-- Looking for ignition-plugin1 -- found version 1.2.0
-- Searching for dependencies of ignition-plugin1
-- Searching for <ignition-plugin1> component [all]
-- Looking for all libraries of ignition-plugin1 -- found version 1.2.0
-- Looking for ignition-plugin1 -- found version 1.2.0
-- Looking for ignition-plugin1-loader -- found version 1.2.0
-- Searching for dependencies of ignition-plugin1-loader
-- Looking for ignition-plugin1-register -- found version 1.2.0
-- Searching for dependencies of ignition-plugin1-register
-- Looking for ignition-plugin1 - found

-- Found FreeImage: TRUE (Required is at least version "3.9") 
-- Looking for FreeImage - found

-- Found OpenGL: /usr/local/lib/x86_64-linux-gnu/libOpenGL.so   
-- Looking for OpenGL - found

-- Checking for module 'OGRE-RTShaderSystem >= 1.9'
--   Found OGRE-RTShaderSystem , version 1.9.0
-- Checking for module 'OGRE-Terrain >= 1.9'
--   Found OGRE-Terrain , version 1.9.0
-- Checking for module 'OGRE-Overlay >= 1.9'
--   Found OGRE-Overlay , version 1.9.0
-- Looking for IgnOGRE - found

-- Boost version: 1.65.1
-- -- Finding OGRE 2.1
-- Looking for IgnOGRE2 - found

CUDA_TOOLKIT_ROOT_DIR not found or specified
-- Could NOT find CUDA (missing: CUDA_TOOLKIT_ROOT_DIR CUDA_NVCC_EXECUTABLE CUDA_INCLUDE_DIRS CUDA_CUDART_LIBRARY) 
-- optix library not found.  Please locate before proceeding.
-- OptiX headers (optix.h and friends) not found.  Please locate before proceeding.
-- optix Prime library not found.  Please locate before proceeding.
-- Could NOT find OptiX (missing: OptiX_FOUND) (Required is at least version "3.8.0")
-- Looking for OptiX - not found

-- 
-- Searching for host SSE information
-- SSE2 found
-- SSE3 found
-- SSE4.1 found
-- SSE4.2 found
-- Configuring library: ignition-rendering5
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Adding 34 UNIT tests
-- Adding 9 INTEGRATION tests
-- Adding 1 PERFORMANCE tests
-- No tests have been specified for REGRESSION
-- Configuring library: ignition-rendering5-ogre
-- No tests have been specified for UNIT
-- Configuring library: ignition-rendering5-ogre2
-- No tests have been specified for UNIT
-- Adding codecheck target
-- Build configuration successful
-- Build type: RelWithDebInfo
-- Install prefix: /usr
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Configuring done
-- Generating done
-- Build files have been written to: /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/build

INTEGRATION_camera test failed - is that known flaky?

      Start 76: INTEGRATION_camera

76: Test command: /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/build/bin/INTEGRATION_camera "--gtest_output=xml:/var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/build/test_results/INTEGRATION_camera.xml"
76: Test timeout computed to be: 240
76: [==========] Running 8 tests from 1 test case.
76: [----------] Global test environment set-up.
76: [----------] 8 tests from Camera/CameraTest
76: [ RUN      ] Camera/CameraTest.Track/ogre2
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32mignition-rendering-ogre2�[0m�[1;32m]�[0m�[1;32m�[0m
76: [       OK ] Camera/CameraTest.Track/ogre2 (347 ms)
76: [ RUN      ] Camera/CameraTest.Track/optix
76: �[1;31m[Err] [RenderEngineManager.cc:461] �[0m�[1;31mFailed to load plugin [�[0m�[1;31moptix�[0m�[1;31m] : couldn't find shared library.�[0m�[1;31m�[0m
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32moptix�[0m�[1;32m]�[0m�[1;32m�[0m
76: �[1;36m[Dbg] [camera.cc:61] �[0m�[1;36mEngine '�[0m�[1;36moptix�[0m�[1;36m' is not supported�[0m�[1;36m�[0m
76: [       OK ] Camera/CameraTest.Track/optix (1 ms)
76: [ RUN      ] Camera/CameraTest.Follow/ogre2
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32mignition-rendering-ogre2�[0m�[1;32m]�[0m�[1;32m�[0m
76: [       OK ] Camera/CameraTest.Follow/ogre2 (78 ms)
76: [ RUN      ] Camera/CameraTest.Follow/optix
76: �[1;31m[Err] [RenderEngineManager.cc:461] �[0m�[1;31mFailed to load plugin [�[0m�[1;31moptix�[0m�[1;31m] : couldn't find shared library.�[0m�[1;31m�[0m
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32moptix�[0m�[1;32m]�[0m�[1;32m�[0m
76: �[1;36m[Dbg] [camera.cc:292] �[0m�[1;36mEngine '�[0m�[1;36moptix�[0m�[1;36m' is not supported�[0m�[1;36m�[0m
76: [       OK ] Camera/CameraTest.Follow/optix (0 ms)
76: [ RUN      ] Camera/CameraTest.Visibility/ogre2
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32mignition-rendering-ogre2�[0m�[1;32m]�[0m�[1;32m�[0m
76: [       OK ] Camera/CameraTest.Visibility/ogre2 (290 ms)
76: [ RUN      ] Camera/CameraTest.Visibility/optix
76: �[1;31m[Err] [RenderEngineManager.cc:461] �[0m�[1;31mFailed to load plugin [�[0m�[1;31moptix�[0m�[1;31m] : couldn't find shared library.�[0m�[1;31m�[0m
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32moptix�[0m�[1;32m]�[0m�[1;32m�[0m
76: �[1;36m[Dbg] [camera.cc:409] �[0m�[1;36mEngine '�[0m�[1;36moptix�[0m�[1;36m' is not supported�[0m�[1;36m�[0m
76: [       OK ] Camera/CameraTest.Visibility/optix (0 ms)
76: [ RUN      ] Camera/CameraTest.VisualAt/ogre2
76: �[1;32m[Msg] �[0m�[1;32mLoading plugin [�[0m�[1;32mignition-rendering-ogre2�[0m�[1;32m]�[0m�[1;32m�[0m
76: /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/ign-rendering/test/integration/camera.cc:254: Failure
76: Expected: (nullptr) != (vis), actual: (nullptr) vs 16-byte object <00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>
76: X: 300
76: /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/ign-rendering/test/integration/camera.cc:262: Failure
76: Expected equality of these values:
76:   nullptr
76:     Which is: (nullptr)
76:   vis
76:     Which is: 16-byte object <40-A5 77-F0 53-56 00-00 D0-A6 77-F0 53-56 00-00>
76: Found [box] at X [400]
76: /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/ign-rendering/test/integration/camera.cc:268: Failure
76: Expected: (nullptr) != (vis), actual: (nullptr) vs 16-byte object <00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>
76: X: 600
76: /var/lib/jenkins/workspace/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/ign-rendering/test/integration/camera.cc:268: Failure
76: Expected: (nullptr) != (vis), actual: (nullptr) vs 16-byte object <00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>
76: X: 700
76: [  FAILED  ] Camera/CameraTest.VisualAt/ogre2, where GetParam() = "ogre2" (258 ms)
76: [ RUN      ] Camera/CameraTest.VisualAt/optix
76: �[1;36m[Dbg] [camera.cc:186] �[0m�[1;36mVisualAt not supported yet in rendering engine: �[0m�[1;36moptix�[0m�[1;36m�[0m
76: [       OK ] Camera/CameraTest.VisualAt/optix (0 ms)
76: [----------] 8 tests from Camera/CameraTest (974 ms total)
76: 
76: [----------] Global test environment tear-down
76: [==========] 8 tests from 1 test case ran. (974 ms total)
76: [  PASSED  ] 7 tests.
76: [  FAILED  ] 1 test, listed below:
76: [  FAILED  ] Camera/CameraTest.VisualAt/ogre2, where GetParam() = "ogre2"
76: 
76:  1 FAILED TEST
76/91 Test #76: INTEGRATION_camera ....................***Failed    1.03 sec

[Blast545]

@sloretz I think this warning was addressed with: ign-rendering#411 and it should be forward ported

[iche033]

forward ported in #424

[iche033]

@sloretz, I think the forward port should fix the issue. Can we close this?

related changes in the forward port:
https://github.com/ignitionrobotics/ign-rendering/pull/424/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR68-R80

[sloretz]

Closing, fix is being forward ported