LuxCore Render Engine Example #505

WilliamLewww · 2021-12-06T21:11:46Z

🎉 LuxCore Render Engine

Example renders:

Summary

This pull request creates an example plugin using the LuxCore render engine. The implementation is incomplete and only supports basic scenes. Some parameters of the engine are hardcoded and can be adjusted for different effects:

https://wiki.luxcorerender.org/LuxCore_SDL_Reference_Manual_v2.5

How to build and run the example

Download the LuxCoreSDK using the following link (make sure to download the SDK and not the standalone): https://luxcorerender.org/download/

Build and install ign-rendering:

cd ign-rendering
mkdir build
cd build
cmake ..
make install

Build the example:

export LUXCORE_SDK_PATH=<PATH_TO_LUXCORE_SDK_DIRECTORY>
cd ../examples/lux_core_engine
mkdir build
cd build
cmake ..
make

Run the example:

export IGN_RENDERING_PLUGIN_PATH=$PWD
./simple_demo

Checklist

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)
Updated migration guide (as needed)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

codecov · 2021-12-06T21:41:29Z

Codecov Report

Merging #505 (1bfb91d) into ign-rendering6 (87b30ad) will decrease coverage by 2.27%.
The diff coverage is 57.60%.

❗ Current head 1bfb91d differs from pull request most recent head 7717b2e. Consider uploading reports for the commit 7717b2e to get more accurate results

@@                Coverage Diff                 @@
##           ign-rendering6     #505      +/-   ##
==================================================
- Coverage           57.80%   55.53%   -2.28%     
==================================================
  Files                 161      195      +34     
  Lines               15851    19698    +3847     
==================================================
+ Hits                 9163    10939    +1776     
- Misses               6688     8759    +2071

Impacted Files	Coverage Δ
include/ignition/rendering/ArrowVisual.hh	`100.00% <ø> (ø)`
include/ignition/rendering/AxisVisual.hh	`0.00% <ø> (-100.00%)`	⬇️
include/ignition/rendering/Camera.hh	`100.00% <ø> (ø)`
include/ignition/rendering/Geometry.hh	`100.00% <ø> (ø)`
include/ignition/rendering/GpuRays.hh	`0.00% <ø> (ø)`
include/ignition/rendering/HeightmapDescriptor.hh	`100.00% <ø> (ø)`
include/ignition/rendering/JointVisual.hh	`0.00% <0.00%> (ø)`
include/ignition/rendering/Light.hh	`100.00% <ø> (ø)`
include/ignition/rendering/LightVisual.hh	`100.00% <ø> (ø)`
include/ignition/rendering/Material.hh	`100.00% <ø> (ø)`
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b30ad...7717b2e. Read the comment docs.

codecov · 2022-05-27T18:08:26Z

Codecov Report

Merging #505 (7ca2b8f) into ign-rendering6 (a3dc1ae) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-rendering6     #505   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3dc1ae...7ca2b8f. Read the comment docs.

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

ahcorde

examples/lux_core_engine/README.md is empty, are you planning to add some docs here ? otherwise remove this file

examples/lux_core_engine/CMakeLists.txt

examples/lux_core_engine/GlutWindow.cc

examples/lux_core_engine/LuxCoreEngineVisual.hh

examples/lux_core_engine/Main.cc

* state of branch Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Update README.md Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added render engine example Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Render white box Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Reverted simple demo Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed camera image size Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added lens trace example Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added sample render for luxcore Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added ProRender base plugin files Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added dynamic scene creation with luxcore Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added mesh class Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Split classes to separate files Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Add mesh to scene with factory Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added plane Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Moved RenderSession to Camera Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed luxcore initialization Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Wait for render to finish Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed race condition Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Keep render session alive for accumulation Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Use CUDA for renders Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added directional light Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed camera tracking Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added Duck model Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added normals and UV coordinates to submeshes Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Updated format of examples Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed header order error Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Remodev pro-render example Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed versioning Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Cleaned code formatting Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Use cornell box for example Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added environment variable warnings Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Undo edits to simple demo Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Removed lights outside of scene Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Removed outdated comments Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added render engine output when running demo Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added image maps with each mesh import Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added textures into LuxCore SDL Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed loading data from gz::common::image Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added duck to cornell box Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * PR review comments resolved Signed-off-by: Sanjuksha Nirgude <sanjuksha@system76-pc.localdomain> * allow user to configure render engine type Signed-off-by: Ian Chen <ichen@osrfoundation.org> * PR review comments resolved Signed-off-by: Sanjuksha Nirgude <sanjuksha@system76-pc.localdomain> * Added Documentation Signed-off-by: Sanjuksha Nirgude <sanjuksha@gmail.com> * update doc, style changes Signed-off-by: Ian Chen <ichen@osrfoundation.org> Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com> Signed-off-by: Sanjuksha Nirgude <sanjuksha@system76-pc.localdomain> Signed-off-by: Ian Chen <ichen@osrfoundation.org> Signed-off-by: Sanjuksha Nirgude <sanjuksha@gmail.com> Co-authored-by: Tomas Lorente <jtlorente@ekumenlabs.com> Co-authored-by: William Lew <WilliamMilesLew@gmail.com> Co-authored-by: Sanjuksha Nirgude <sanjuksha@system76-pc.localdomain> Co-authored-by: Ian Chen <ichen@osrfoundation.org>

github-actions bot added the 🏯 fortress Ignition Fortress label Dec 6, 2021

WilliamLewww changed the title ~~LuxCore Render Engine (Work in Progress)~~ LuxCore Render Engine Example Jun 2, 2022

WilliamLewww force-pushed the wlew/render_engine branch from 59ea087 to efd1736 Compare June 2, 2022 17:12

Lobotuerk and others added 22 commits June 2, 2022 10:12

state of branch

e2d7ef5

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Update README.md

7529073

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added render engine example

0b1c3c7

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Render white box

85871bc

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Reverted simple demo

02fd831

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Fixed camera image size

a047a74

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added lens trace example

6417713

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added sample render for luxcore

dc21b95

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added ProRender base plugin files

90a9e21

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added dynamic scene creation with luxcore

9de5639

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added mesh class

cf2f1ef

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Split classes to separate files

019d049

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Add mesh to scene with factory

e7f00a1

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added plane

215333e

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Moved RenderSession to Camera

de4ce76

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Fixed luxcore initialization

e6b763f

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Wait for render to finish

a3d6f78

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Fixed race condition

52910ae

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Keep render session alive for accumulation

9b665eb

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Use CUDA for renders

e8ca3ee

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added directional light

3a44884

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Fixed camera tracking

6cf610a

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

WilliamLewww added 4 commits June 2, 2022 10:12

Fixed versioning

1587f76

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Cleaned code formatting

339d4ad

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Use cornell box for example

efb05b9

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added environment variable warnings

48f6d95

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

WilliamLewww force-pushed the wlew/render_engine branch from efd1736 to 48f6d95 Compare June 2, 2022 17:12

Merge branch 'ign-rendering6' into wlew/render_engine

1415d18

WilliamLewww marked this pull request as ready for review June 2, 2022 17:13

WilliamLewww requested a review from iche033 as a code owner June 2, 2022 17:13

WilliamLewww added 4 commits June 3, 2022 08:33

Undo edits to simple demo

c2b661d

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Removed lights outside of scene

76e4bf8

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Removed outdated comments

11f5d5c

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added render engine output when running demo

9375089

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

WilliamLewww force-pushed the wlew/render_engine branch from f893d67 to 9375089 Compare June 3, 2022 15:33

WilliamLewww added 4 commits June 3, 2022 11:51

Added image maps with each mesh import

2a96291

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added textures into LuxCore SDL

71867d0

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Fixed loading data from gz::common::image

1dd1ca4

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

Added duck to cornell box

7ca2b8f

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>

chapulina mentioned this pull request Jun 15, 2022

🎈 6.5.0 #651

Merged

7 tasks

chapulina requested a review from ahcorde June 27, 2022 18:56

ahcorde requested changes Jun 30, 2022

View reviewed changes

chapulina added the enhancement New feature or request label Jul 23, 2022

nkoenig requested review from ahcorde and nkoenig August 22, 2022 18:52

iche033 assigned sanjuksha Aug 24, 2022

sanjuksha mentioned this pull request Sep 19, 2022

From - LuxCore Render Engine Example #505 #727

Merged

8 tasks

sanjuksha closed this Oct 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LuxCore Render Engine Example #505

LuxCore Render Engine Example #505

WilliamLewww commented Dec 6, 2021 •

edited

Loading

codecov bot commented Dec 6, 2021

codecov bot commented May 27, 2022 •

edited

Loading

ahcorde left a comment

LuxCore Render Engine Example #505

LuxCore Render Engine Example #505

Conversation

WilliamLewww commented Dec 6, 2021 • edited Loading

🎉 LuxCore Render Engine

Summary

How to build and run the example

Checklist

codecov bot commented Dec 6, 2021

Codecov Report

codecov bot commented May 27, 2022 • edited Loading

Codecov Report

ahcorde left a comment

Choose a reason for hiding this comment

WilliamLewww commented Dec 6, 2021 •

edited

Loading

codecov bot commented May 27, 2022 •

edited

Loading