Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition #877

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Remove ignition #877

merged 6 commits into from
Aug 3, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Remove ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig requested a review from iche033 as a code owner July 27, 2023 12:42
@nkoenig nkoenig marked this pull request as draft July 27, 2023 12:42
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #877 (b0646b2) into main (e58870c) will increase coverage by 0.03%.
The diff coverage is 76.47%.

❗ Current head b0646b2 differs from pull request most recent head b1b2a51. Consider uploading reports for the commit b1b2a51 to get more accurate results

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   75.09%   75.13%   +0.03%     
==========================================
  Files         176      176              
  Lines       16859    16835      -24     
==========================================
- Hits        12661    12649      -12     
+ Misses       4198     4186      -12     
Files Changed Coverage Δ
src/RenderEngineManager.cc 79.44% <76.47%> (+2.55%) ⬆️

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig marked this pull request as ready for review August 2, 2023 12:26
@iche033 iche033 merged commit 2286452 into main Aug 3, 2023
6 checks passed
@iche033 iche033 deleted the nkoenig/remove-ign branch August 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants