Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GPU lidar tests on macOS #163

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 6, 2021

🦟 Bug fix

related to #157

Summary

gpu_lidar_sensor integration tests started failing after we switched the default render engine to ogre 1.x. Disabling them for now to get green homebew CI builds.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #163 (67675c4) into ign-sensors6 (b0c61c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors6     #163   +/-   ##
=============================================
  Coverage         75.90%   75.90%           
=============================================
  Files                27       27           
  Lines              2747     2747           
=============================================
  Hits               2085     2085           
  Misses              662      662           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c61c5...67675c4. Read the comment docs.

@iche033 iche033 merged commit 264e297 into ign-sensors6 Oct 6, 2021
@iche033 iche033 deleted the disable_lidar_test_macos branch October 6, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants