Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ign-sensors2 ➡️ ign-sensors3 #251

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Merge ign-sensors2 ➡️ ign-sensors3 #251

merged 5 commits into from
Jul 28, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-sensors2 ➡️ ign-sensors3

Branch comparision: ign-sensors3...ign-sensors2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 5 commits December 28, 2020 10:16
@chapulina
⬆️ 2.9.1 🏁 (#70)
9226e23 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@nkoenig @chapulina
Change IGN_DESIGNATION to GZ_DESIGNATION (#246)
2180d1f 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Merge branch 'ign-sensors1' into 1-2-designation
e54e55e
@chapulina
1 ➡️ 2 (#250)
33b3715 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
2 ➡️ 3
3f9463b 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner July 28, 2022 16:39
@chapulina chapulina requested a review from nkoenig July 28, 2022 16:39
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #251 (6ed7b83) into ign-sensors3 (a82550d) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ed7b83 differs from pull request most recent head 3f9463b. Consider uploading reports for the commit 3f9463b to get more accurate results

@@              Coverage Diff              @@
##           ign-sensors3     #251   +/-   ##
=============================================
  Coverage         77.57%   77.57%           
=============================================
  Files                23       23           
  Lines              2377     2377           
=============================================
  Hits               1844     1844           
  Misses              533      533

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82550d...3f9463b. Read the comment docs.

@chapulina chapulina enabled auto-merge July 28, 2022 16:59
@nkoenig nkoenig disabled auto-merge July 28, 2022 19:29
@nkoenig nkoenig merged commit 6e0b3ae into ign-sensors3 Jul 28, 2022
@nkoenig nkoenig deleted the chapulina/2_to_3 branch July 28, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @nkoenig