Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps for Dome: use msgs6, transport9, sdf10 #31

Merged
merged 7 commits into from
Jul 29, 2020
Merged

Update deps for Dome: use msgs6, transport9, sdf10 #31

merged 7 commits into from
Jul 29, 2020

Conversation

j-rivero
Copy link
Contributor

As part of the works of gazebo-tooling/gazebodistro#5 bump the use of msgs to major version 6, transport to 9, sdf to 10.

@j-rivero
Update deps for Dome: use msgs6, transport9, sdf10
aedad7c 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from iche033 as a code owner July 10, 2020 12:11
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 10, 2020
@j-rivero
Copy link
Contributor Author

CI is going to need gazebosim/gz-transport#149 and osrf/homebrew-simulation#1063 for Brew

chapulina
chapulina approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs to be merged first

@chapulina
bump deps on actions
cf9a8bc 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request Jul 21, 2020
Merged
@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina chapulina mentioned this pull request Jul 27, 2020
Merged
@chapulina
Copy link
Contributor

Needed for Windows CI: gazebo-tooling/gazebodistro#7

chapulina added 2 commits July 27, 2020 12:10
@chapulina
install after make on CI
375a265 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
install xvfb
cc877e2 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
set -e
f8755ff 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request Jul 27, 2020
Merged
@j-rivero
Use EXPECT_NEAR for DepthCameraSensorTest to make github actions happy
e0be114 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@codecov
Copy link

codecov bot commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #31 into master will increase coverage by 17.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   59.63%   77.31%   +17.67%     
===========================================
  Files          16       23        +7     
  Lines         976     2261     +1285     
===========================================
+ Hits          582     1748     +1166     
- Misses        394      513      +119
Impacted Files Coverage Δ
src/Lidar.cc 73.88% <0.00%> (ø)
include/ignition/sensors/Manager.hh 90.00% <0.00%> (ø)
src/CameraSensor.cc 76.95% <0.00%> (ø)
src/GpuLidarSensor.cc 87.58% <0.00%> (ø)
src/RgbdCameraSensor.cc 76.95% <0.00%> (ø)
src/DepthCameraSensor.cc 74.47% <0.00%> (ø)
src/ThermalCameraSensor.cc 57.39% <0.00%> (ø)
src/ImuSensor.cc 88.34% <0.00%> (+1.94%) ⬆️
src/SensorFactory.cc 51.89% <0.00%> (+2.53%) ⬆️
src/Sensor.cc 92.30% <0.00%> (+10.25%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4334b...e0be114. Read the comment docs.

@j-rivero
Copy link
Contributor Author

test are passing in github action and I can not see why the result is a failure, I was not able to see in the whole log anything pointing to a problem. Jenkins is out of combat today, going to merge it and will track github action problem in a new PR

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina chapulina merged commit 03e7f51 into master Jul 29, 2020
@chapulina chapulina deleted the update_dome_versions branch July 29, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig nkoenig approved these changes

@iche033 iche033 Awaiting requested review from iche033

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @chapulina @nkoenig