Set lens intrinsics in Depth and Rgbd camera sensors #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set lens intrinsics in Depth and Rgbd camera sensors Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
shameekganguly
changed the title
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
ahcorde
reviewed
Oct 2, 2023
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 72.76% 72.32% -0.45%
==========================================
Files 36 37 +1
Lines 4968 5048 +80
==========================================
+ Hits 3615 3651 +36
- Misses 1353 1397 +44
|
iche033
reviewed
Oct 2, 2023
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
iche033
approved these changes
Oct 4, 2023
|
Looks like there's a windows build regression from this PR. See #391 (comment) |
Merged
9 tasks
|
https://github.com/Mergifyio backport ign-sensors6 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Refactor projection matrix utility functions to CameraSensorUtil and set lens intrinsics in Depth and Rgbd camera sensors --------- Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com> (cherry picked from commit bd695b2) # Conflicts: # src/CameraSensor.cc # src/DepthCameraSensor.cc # src/RgbdCameraSensor.cc
ahcorde
added a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor projection matrix utility functions to CameraSensorUtil and set lens intrinsics in Depth and Rgbd camera sensors