[FIX] frame_id for depth camera point cloud in Fortress

[MrKeith99]

Fixes #239 and husarion/rosbot_ros#55 for Gazebo Fortress

Summary

Using ignition_frame_id did not change the frame id in the depth camera point cloud message.

With this fix, the depth camera point cloud message's frame id will be updated according to the set ignition_frame_id.

🦟 Bug fix

Fixes #

Summary

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Test it

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port <FROM_BRANCH> to <TO_BRANCH>

Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

• Asked team if this is a good time for a release
• There are no changes to be ported from the previous major version
• No PRs targeted at this major version are close to getting in
• Bumped minor for new features, patch for bug fixes
• Updated changelog
• Updated migration guide (as needed)
• Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[iche033]

I tested running fortress with the current ign-sensors6 branch, and <ignition_frame_id> works for me. Do you have a minimal example that shows <ignition_frame_id> is not working?

Here's my test world file: depth_frame_id.sdf

To run:

ign gazebo -v 4 -r  depth_frame_id.sdf

verify frame id:

ign topic -e -t /depth/points | grep header -A 8

and it prints out:

header {
  stamp {
    nsec: 784000000
  }
  data {
    key: "frame_id"
    value: "my_frame_id"
  }
  data {
--

the frame id is my_frame_id which is what I set in the <ignition_frame_id> field in depth_frame_id.sdf