-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows fix #250
Windows fix #250
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 89.01% 89.03% +0.02%
==========================================
Files 49 49
Lines 4653 4653
==========================================
+ Hits 4142 4143 +1
+ Misses 511 510 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be nice to backport it at some point.
Backport from gazebosim#250
Backport from gazebosim#250 Signed-off-by: Silvio <silvio@traversaro.it>
Backport from #250 Signed-off-by: Silvio <silvio@traversaro.it> Signed-off-by: Silvio <silvio@traversaro.it>
🎉 New feature
Summary
This PR is required by gazebosim/gz-launch#120
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge