Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errno #254

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Errno #254

merged 2 commits into from
Aug 12, 2021

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Aug 10, 2021

Use errno to show additional error information.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 10, 2021
@caguero caguero changed the base branch from ign-transport8 to ign-transport9 August 10, 2021 19:03
@caguero caguero added 🔮 dome Ignition Dome and removed 🏰 citadel Ignition Citadel labels Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #254 (5b6dbff) into ign-transport9 (b58e30c) will decrease coverage by 0.07%.
The diff coverage is 30.00%.

❗ Current head 5b6dbff differs from pull request most recent head 96ce3c0. Consider uploading reports for the commit 96ce3c0 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport9     #254      +/-   ##
==================================================
- Coverage           88.98%   88.91%   -0.08%     
==================================================
  Files                  49       49              
  Lines                4668     4674       +6     
==================================================
+ Hits                 4154     4156       +2     
- Misses                514      518       +4     
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.06% <30.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f083307...96ce3c0. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO ?

@chapulina
Copy link
Contributor

DCO ?

The DCO checker doesn't act well when the PR is targeted at the wrong branch and then updated. It looks like it's a false-negative to me.

@nkoenig
Copy link
Contributor

nkoenig commented Aug 12, 2021

@caguero we are clear to get this in and make a release.

@caguero caguero merged commit 5d0820a into ign-transport9 Aug 12, 2021
@caguero caguero deleted the errno branch August 12, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants