tweaks documentation

[ahcorde]

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

🦟 Bug fix

Summary

Some fixes to improve macos support.

I'm not able to compile publisher_custom_msg and subscriber_custom_msgs because of this error:

msgs/stringmsg.pb.h:10:10: fatal error: 'google/protobuf/port_def.inc' file not found
#include <google/protobuf/port_def.inc>

any idea @scpeters ?

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #265 (556cd95) into main (73bfba7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   89.06%   89.07%           
=======================================
  Files          51       51           
  Lines        4766     4769    +3     
=======================================
+ Hits         4245     4248    +3     
  Misses        521      521           

Impacted Files	Coverage Δ
src/NodeSharedPrivate.hh	100.00% <ø> (ø)
src/Discovery.cc	77.77% <100.00%> (+2.77%)	⬆️
src/NodeShared.cc	80.27% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bfba7...556cd95. Read the comment docs.

[scpeters]

I tried fixing some clang compiler warnings in 51df6a8, but for some reason it breaks the Ubuntu bionic action workflow (though it doesn't affect the jenkins build using bionic)

[ahcorde]

I tried fixing some clang compiler warnings in 51df6a8, but for some reason it breaks the Ubuntu bionic action workflow (though it doesn't affect the jenkins build using bionic)

  ../lib/libignition-transport11.so.11.0.0~pre1: undefined reference to `ignition::transport::v11::NodeSharedPrivate::Timeout'

@j-rivero any thoughts?

[chapulina]

CI is happy