Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : ign-transport #310

Merged
merged 4 commits into from
May 11, 2022
Merged

ign -> gz Header Migration : ign-transport #310

merged 4 commits into from
May 11, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from caguero as a code owner May 3, 2022 21:05
@methylDragon methylDragon marked this pull request as draft May 3, 2022 21:05
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 3, 2022
@methylDragon
Move header files with git mv (#310)
57ea474 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Create redirection aliases (#310)
aad3b45 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#310)
be211a5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Migrate CMake Files (#310)
1cce238 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Create redirection aliases (#310)
c939803 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#310)
f656aba 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Migrate CMake Files (#310)
88699cf 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon marked this pull request as ready for review May 3, 2022 21:24
@methylDragon
Copy link
Contributor Author

methylDragon commented May 3, 2022 •
edited
Loading

CI is pending msgs

I had to install test_config.h for ignition to run tests properly (without reworking the test CMakeLists)

EDIT: I guess I could exclude the files from the install invocation... I think I'll do that, give me a sec

Done https://github.com/ignitionrobotics/ign-transport/compare/88699cf7dc5908e2390903302fc6cb15b525e7db..c05b4e1741a05a9379db1f9281b8955c8ca6d289

methylDragon added a commit that referenced this pull request May 3, 2022
@methylDragon
Migrate CMake Files (#310)
c05b4e1 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon mentioned this pull request May 3, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 4, 2022
chapulina
chapulina approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is 🟢

log/include/ignition/transport/log/test_config.h Outdated Show resolved Hide resolved
@methylDragon
Create redirection aliases (#310)
f1e94a7 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 4, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#310)
65128ef 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 4, 2022
@methylDragon
Migrate CMake Files (#310)
a35ec50 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate sources in src, test, examples, and include (#310)
f618941 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 4, 2022
@methylDragon
Migrate CMake Files (#310)
27bc186 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate CMake Files (#310)
3aa586f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Contributor Author

Note to self: Pending ign-msgs

chapulina
chapulina approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 with 🟢 CI

@methylDragon
Copy link
Contributor Author

We're pending gz-msgs

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #310 (3aa586f) into main (d2454eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          24       24           
=======================================
  Hits           16       16           
  Misses          8        8
Impacted Files Coverage Δ
include/ignition/transport/test_config.h
include/gz/transport/test_config.h 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2454eb...3aa586f. Read the comment docs.

@methylDragon methylDragon merged commit 703f52c into main May 11, 2022
@methylDragon methylDragon deleted the header_migration branch May 11, 2022 03:59
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Move header files with git mv (#310)
65bcc4c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Create redirection aliases (#310)
30623f4 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#310)
ac4c6ae 
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina