[foxy] Edifice support #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
ahcorde
approved these changes
Mar 17, 2021
ahcorde
requested changes
Mar 17, 2021
There was a problem hiding this comment.
4: Test command: /usr/bin/python3 "-u" "/opt/ros/foxy/share/ament_cmake_test/cmake/run_test.py" "/root/ws/build/ros_ign_image/test_results/ros_ign_image/lint_cmake.xunit.xml" "--package-name" "ros_ign_image" "--output-file" "/root/ws/build/ros_ign_image/ament_lint_cmake/lint_cmake.txt" "--command" "/opt/ros/foxy/bin/ament_lint_cmake" "--xunit-file" "/root/ws/build/ros_ign_image/test_results/ros_ign_image/lint_cmake.xunit.xml"
4: Test timeout computed to be: 60
4: -- run_test.py: invoking following command in '/code/ros_ign_image':
4: - /opt/ros/foxy/bin/ament_lint_cmake --xunit-file /root/ws/build/ros_ign_image/test_results/ros_ign_image/lint_cmake.xunit.xml
4: CMakeLists.txt:20: Extra spaces between 'if' and its () [whitespace/extra]
4: CMakeLists.txt:29: Extra spaces between 'elseif' and its () [whitespace/extra]
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
CI should be fixed by 9a6b745 |
ahcorde
requested changes
Mar 17, 2021
There was a problem hiding this comment.
the lint_cmake is still there https://travis-ci.org/github/ignitionrobotics/ros_ign/jobs/763301487
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
ahcorde
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Support the upcoming Ignition release.
Test it
export IGNITION_VERSION=edificeChecklist
Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸