Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport iron] SensorNoise msg bridging (#417) #425

Merged
merged 3 commits into from
Jun 21, 2023
Merged

[backport iron] SensorNoise msg bridging (#417) #425

merged 3 commits into from
Jun 21, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 21, 2023

🎉 New feature

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@adityapande-1995 @ahcorde
SensorNoise msg bridging (#417)
4e7a5f9 
Signed-off-by: Aditya Pande <adityapande@google.com>
@ahcorde ahcorde self-assigned this Jun 21, 2023
@ahcorde
make linters happyu
1ddd9b7 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
azeey
azeey approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one nitpick.

ros_gz_bridge/README.md Outdated Show resolved Hide resolved
@ahcorde
nitpick
55daf6f 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 115aa6b into iron Jun 21, 2023
@ahcorde ahcorde deleted the ahcorde/iron/backport/417 branch June 21, 2023 21:54
ahcorde added a commit that referenced this pull request Jun 22, 2023
@ahcorde @adityapande-1995
[backport iron] SensorNoise msg bridging (#417) (#425)
6d12a72 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @azeey @adityapande-1995