Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Foxy CI #94

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Update Foxy CI #94

merged 2 commits into from
Jul 22, 2020

Conversation

chapulina
Copy link
Contributor

Install Citadel dependencies from rosdep keys.

@chapulina
Update Foxy CI
932032f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added ROS 2 ROS 2 🏰 citadel Ignition Citadel labels Jul 22, 2020
@chapulina chapulina mentioned this pull request Jul 22, 2020
Closed
j-rivero
j-rivero approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to remove all those hardcoded packages! Minor suggestion for CI, looks good.

@chapulina
Remove IGNITION_VERSION
5bf9b5c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit c5eb32f into ros2 Jul 22, 2020
@chapulina chapulina deleted the chapulina/foxy_ci branch July 22, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @j-rivero