Fix redirection of spec pages #110
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Redirection of spec pages is not currently working because of some a logic error in the code. The
/specstring is part of the url path not the search paramters, so the regex match was faling. Theifblock that handles the resultingnew_locvariable was also in the wrong scope.Test with:
http://sdformat.org/spec/?ver=1.12&elem=collision
http://localhost:3000/spec/?ver=1.12&elem=collision
Note that, testing redirection with
nanoc livedoesn't work all the time. If the/is missing right afterspec, the server doesn't seem to add that, but testing withpython3 -m http.server 3000shows that the redirection works with and without the added/, i.e, both http://localhost:3000/spec/?ver=1.12&elem=collision and http://localhost:3000/spec?ver=1.12&elem=collision work.Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.