Merge branch 'sdf9' into sdf9-add-missing-plugin

gazebosim · Aug 27, 2021 · 4b838ad · 4b838ad
2 parents 7685e16 + e18682d
commit 4b838ad
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
         id: ci
         uses: ignition-tooling/action-ignition-ci@bionic
         with:
-          codecov-token: ${{ secrets.CODECOV_TOKEN }}
+          codecov-enabled: true
   focal-ci:
     runs-on: ubuntu-latest
     name: Ubuntu Focal CI

diff --git a/README.md b/README.md
@@ -17,7 +17,8 @@ allows conversion from previous versions.
 
 Test coverage:
 
-[![codecov](https://codecov.io/bb/osrf/sdformat/branch/default/graph/badge.svg)](https://codecov.io/bb/osrf/sdformat)
+<!-- Note: The branch name in the codecov URL should be updated when forward porting -->
+[![codecov](https://codecov.io/gh/ignitionrobotics/sdformat/branch/sdf9/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/sdformat/branch/sdf9)
 
 # Installation
 

diff --git a/include/sdf/Param.hh b/include/sdf/Param.hh
@@ -244,6 +244,8 @@ namespace sdf
 
     /// \def ParamVariant
     /// \brief Variant type def.
+    /// Note: When a new variant is added, add variant to functions
+    /// ParamPrivate::TypeToString and ParamPrivate::ValueFromStringImpl
     public: typedef std::variant<bool, char, std::string, int, std::uint64_t,
                                    unsigned int, double, float, sdf::Time,
                                    ignition::math::Angle,