Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of bad values (syntactically and semantically) should be more strict #260

Closed
azeey opened this issue Apr 29, 2020 · 2 comments
Closed
Labels

Comments

@azeey
Copy link
Collaborator

azeey commented Apr 29, 2020

Example of bad syntax: #228
Example of bad semantics: RobotLocomotion/drake#12863 (review)

This is actually a spec change; "bad" values should throw an error by design, not be ignored by design. Currently, a negative effort limit implies ignoring a joint limit...

For handling bad semantics, look into using min and max values in the spec descriptions

For non-scalar values like //joint/axis/xyz, libsdformat should enforce that the axis is a unit vector by either re-normalizing or requiring it to be normalized.

Also, spec should say that it will disregard non-unit vectors for axes.

We should do PR for libsdformat10 as an error.

If we have extra time, backport to libsdformat9, but as a warning. (With updates to Gazebo Classic + Ignition Gazebo.)

@azeey azeey added the task label Apr 29, 2020
@azeey
Copy link
Collaborator Author

azeey commented Apr 29, 2020

Addressed by #244 and #259

@scpeters scpeters changed the title Make parsing of bad values (syntactically and semantically) more strict Parsing of bad values (syntactically and semantically) should be more strict Apr 30, 2020
@EricCousineau-TRI
Copy link
Collaborator

Marking as done, but spun off separate issue about //joint/axis/xyz
#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants