-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash completion for flags #1042
Conversation
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pushed small fixes on 488d2ac:
- Use
sdf::Filesystem
to fix Bionic build - Always install CLI files (see [tracker] Remove ignition-tools cmake check in Ignition software gazebo-tooling/release-tools#472)
Codecov Report
@@ Coverage Diff @@
## sdf9 #1042 +/- ##
===========================================
+ Coverage 43.47% 87.59% +44.11%
===========================================
Files 1 64 +63
Lines 23 10061 +10038
===========================================
+ Hits 10 8813 +8803
- Misses 13 1248 +1235
Continue to review full report at Codecov.
|
Follow-up to gazebosim/sdformat#1042. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Follow-up to gazebosim/sdformat#1042. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
🎉 New feature
Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87
Summary
Bash completion, installation, tests.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.