-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ign -> gz : Remove redundant namespace references #1105
Conversation
Codecov Report
@@ Coverage Diff @@
## sdf9 #1105 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 64 64
Lines 10061 10061
=======================================
Hits 8813 8813
Misses 1248 1248
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c09784b
to
7e02d34
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
7e02d34
to
7e3ccfe
Compare
I think the namespace reduction plan in gazebo-tooling/release-tools#784 is useful for eliminating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR isn't strictly helpful for the ignition
migration because this repository doesn't release any code under that namespace, so we shouldn't be using namespace ignition
here.
But I think removing those redundant namespaces doesn't hurt, makes some liner shorter, and the code a bit cleaner. It may just introduce some confusion for functions that aren't clearly from this library, like sdf::split
I just saw @scpeters 's comment, I'm fine declining this PR if that's preferred. |
I have no preferences, but if needed, I can exclude stuff like |
@methylDragon , I'll just close this one for expediency. We don't need to put more time into it. Let's focus on |
Part of: gazebo-tooling/release-tools#784