Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdf9 to sdf12 #1199

Merged
merged 5 commits into from
Nov 16, 2022
Merged

sdf9 to sdf12 #1199

merged 5 commits into from
Nov 16, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Nov 15, 2022

➡️ Forward port

Port sdf9 to sdf12

Branch comparison: sdf12...sdf9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

lopsided98 and others added 5 commits November 8, 2022 23:22
The CMAKE_INSTALL_*DIR variables may be absolute, in which case they must not
be concatenated with CMAKE_INSTALL_PREFIX. If an absolute path is needed,
CMAKE_INSTALL_FULL_*DIR must be used. In other cases, more complex logic may be
required to make packages relocatable in the case that CMAKE_INSTALL_*DIR is
relative.

This patch replaces the custom LIB_INSTALL_DIR and BIN_INSTALL_DIR variables
with the standard GNUInstallDirs variables throughout the code. The custom
variables are still honored if specified manually.

Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Added camera info topic to Camera
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey as a code owner November 15, 2022 12:30
@ahcorde ahcorde self-assigned this Nov 15, 2022
@ahcorde ahcorde requested a review from scpeters as a code owner November 15, 2022 12:30
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 15, 2022
@ahcorde
Copy link
Collaborator Author

ahcorde commented Nov 15, 2022

@azeey I added the new element to 1.8-1.10 .sdf files as well as updating ToElement. Related the camera PR
I included TriggerTopic and Triggered because I was missed

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1199 (64b7a1c) into sdf12 (06b225d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 64b7a1c differs from pull request most recent head c6282bd. Consider uploading reports for the commit c6282bd to get more accurate results

@@           Coverage Diff           @@
##            sdf12    #1199   +/-   ##
=======================================
  Coverage   92.01%   92.02%           
=======================================
  Files          79       79           
  Lines       13058    13071   +13     
=======================================
+ Hits        12015    12028   +13     
  Misses       1043     1043           
Impacted Files Coverage Δ
src/Camera.cc 89.29% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 2dca585 into sdf12 Nov 16, 2022
@scpeters scpeters deleted the ahcorde/sdf9_to_sdf12_15_11_2022 branch November 16, 2022 00:50
@iche033 iche033 mentioned this pull request Feb 27, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants