Update multiple-collision test with justification #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the auto-inertial test with multiple collisions with different densities so that the lumped center of gravity is at the link origin and derives the expected moment of inertia values. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## auto_inertia_mass #1515 +/- ##
====================================================
Coverage ? 92.47%
====================================================
Files ? 138
Lines ? 18332
Branches ? 0
====================================================
Hits ? 16953
Misses ? 1379
Partials ? 0 ☔ View full report in Codecov by Sentry. |
iche033
approved these changes
Dec 13, 2024
iche033
added a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org> update python test Signed-off-by: Ian Chen <ichen@openrobotics.org> udate api doc for resolving auto inertia Signed-off-by: Ian Chen <ichen@openrobotics.org> Add tests for auto-inertial with explicit mass (#1514) * link_dom test: Fix typo Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Test case for auto-inertials with explicit mass Signed-off-by: Steve Peters <scpeters@openrobotics.org> --------- Signed-off-by: Steve Peters <scpeters@openrobotics.org> update doc add comments Signed-off-by: Ian Chen <ichen@openrobotics.org> add one more test with multiple collisions Signed-off-by: Ian Chen <ichen@openrobotics.org> Update mass expectation in auto-inertial tests The mass is no longer explicitly set in these Link tests, so replace the not-equals expectation with an expectation of what the mass should be. Signed-off-by: Steve Peters <scpeters@openrobotics.org> fix build Signed-off-by: Ian Chen <ichen@openrobotics.org> remove empty line Signed-off-by: Ian Chen <ichen@openrobotics.org> remove density warning, fix typo Signed-off-by: Ian Chen <ichen@openrobotics.org> Update multiple-collision test with justification (#1515) Modifies the auto-inertial test with multiple collisions with different densities so that the lumped center of gravity is at the link origin and derives the expected moment of inertia values. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting #1513
Modifies the auto-inertial test with multiple collisions with different densities so that the lumped center of gravity is at the link origin and derives the expected moment of inertia values.