Install exe and spec files to unversioned folders #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename library_location to exe_location * Remove unused library_location_prefix variable Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to osrf/homebrew-simulation
that referenced
this pull request
May 23, 2025
Follow-up to gazebosim/sdformat#1569. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Follow up to gazebo-tooling/release-tools#1244.
Summary
We removed version numbers from package names in many places as part of gazebo-tooling/release-tools#1244, prioritizing the places that most affect users. While reviewing gazebo-release/sdformat16-release#5, I realized that we can install the executable commands and SDFormat spec file to unversioned folders as well, which should make our packaging metadata easier to maintain.
Test it
I will update gazebo-release/sdformat16-release#5 to work with this branch and test by building a new nightly deb with both branches.I tested with gazebo-release/sdformat16-release#5 (which has already been merged) and confirmed that this works with the current debian metadata.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.