Bazel updates: prepare for BCR release automation #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Contributor
Author
|
Note: this PR cannot be forward-ported to |
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
iche033
approved these changes
Dec 10, 2025
Contributor
Author
|
MacOS github CI failures are unrelated. |
shameekganguly
added a commit
that referenced
this pull request
Dec 11, 2025
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Contributor
Author
Manual forward port to main: #1599 |
shameekganguly
added a commit
that referenced
this pull request
Dec 12, 2025
The change had to be amended to apply it on main. Specifically, the repo archive_overrides in MODULE.bazel for gz deps was removed in that PR on the Jetty branch, but we want to preserve it on main to ensure CI uses gz deps from HEAD. -- Original PR description Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR. Drop repo_name, which removes the need to patch MODULE.bazel when pushing a release to BCR. repo_name is not a required field and can be added on the client side during import if needed to disambiguate packages. Add compatibility_level to match what is set in BCR Bump buildifier_prebuilt since version 8.2.0 has a bug in bazel 8 presubmits. Also remove unnecessary buildifier targets in test/BUILD.bazel; the top-level targets in BUILD.bazel cover the whole repo. Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
shameekganguly
added a commit
that referenced
this pull request
Dec 12, 2025
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
shameekganguly
added a commit
that referenced
this pull request
Dec 16, 2025
Manually backported to use Ionic packages for gz deps from BCR instead of Jetty deps. -- Original PR description: - Remove archive_override for `gz-utils` and `gz-math` deps and used Jetty packages from BCR instead. As a result, bazel CI will use released versions of gz deps, which is consistent with cmake CI. - Drop `repo_name`, which removes the need to patch MODULE.bazel when pushing a release to BCR. `repo_name` is not a required field and can be added on the client side during import if needed to disambiguate packages. - Add `compatibility_level` to match [what is set in BCR](https://github.com/bazelbuild/bazel-central-registry/blob/ac68ad113a1592ea6dbe4f5cd6ad38ca54887637/modules/sdformat/16.0.0-pre2/MODULE.bazel#L4) - Bump `buildifier_prebuilt` since version 8.2.0 has a bug in [bazel 8 presubmits](bazelbuild/bazel-central-registry#5037 (comment)). Also remove unnecessary buildifier targets in test/BUILD.bazel; the top-level targets in BUILD.bazel cover the whole repo. Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Few small fixes in MODULE.bazel as pre-work to add automation to push new releases to BCR.
gz-utilsandgz-mathdeps and used Jetty packages from BCR instead. As a result, bazel CI will use released versions of gz deps, which is consistent with cmake CI.repo_name, which removes the need to patch MODULE.bazel when pushing a release to BCR.repo_nameis not a required field and can be added on the client side during import if needed to disambiguate packages.compatibility_levelto match what is set in BCRbuildifier_prebuiltsince version 8.2.0 has a bug in bazel 8 presubmits. Also remove unnecessary buildifier targets in test/BUILD.bazel; the top-level targets in BUILD.bazel cover the whole repo.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.