Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchForStuff: add logic to find urdfdom without pkg-config #245

Merged
merged 1 commit into from
Sep 7, 2020
Merged

SearchForStuff: add logic to find urdfdom without pkg-config #245

merged 1 commit into from
Sep 7, 2020

Conversation

traversaro
Copy link
Contributor

This is useful for vcpkg packaging.

azeey
azeey approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thank you.

@scpeters
Copy link
Member

sorry for the delay in reviewing this; do you mind signing your commit? you can optionally rebase at the same time if you want

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #245 into sdf9 will decrease coverage by 0.13%.
The diff coverage is 77.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             sdf9     #245      +/-   ##
==========================================
- Coverage   86.40%   86.27%   -0.14%     
==========================================
  Files          59       59              
  Lines        9053     9177     +124     
==========================================
+ Hits         7822     7917      +95     
- Misses       1231     1260      +29
Impacted Files Coverage Δ
src/parser.cc 77.43% <50.00%> (+0.02%) ⬆️
src/FrameSemantics.cc 76.54% <74.69%> (-0.68%) ⬇️
src/Model.cc 83.00% <76.81%> (-2.07%) ⬇️
src/Actor.cc 83.33% <100.00%> (+0.94%) ⬆️
src/Material.cc 99.29% <100.00%> (+0.03%) ⬆️
src/SemanticPose.cc 100.00% <100.00%> (ø)
src/World.cc 93.12% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a0bd8...cb3bfbc. Read the comment docs.

@traversaro
Copy link
Contributor Author

sorry for the delay in reviewing this; do you mind signing your commit? you can optionally rebase at the same time if you want

Sorry, I had missed your reply.

@scpeters
Copy link
Member

scpeters commented Sep 4, 2020

sorry for the delay in reviewing this; do you mind signing your commit? you can optionally rebase at the same time if you want

Sorry, I had missed your reply.

we added the DCO bot which checks that commits have a sign-off message (use git commit --signoff for example). can you amend your first commit with a sign-off?

@traversaro traversaro force-pushed the search-urdfdom-with-cmake branch 3 times, most recently from b222dba to ac620c4 Compare September 5, 2020 09:34
@traversaro
Copy link
Contributor Author

sorry for the delay in reviewing this; do you mind signing your commit? you can optionally rebase at the same time if you want

Sorry, I had missed your reply.

we added the DCO bot which checks that commits have a sign-off message (use git commit --signoff for example). can you amend your first commit with a sign-off?

Done!

@traversaro
SearchForStuff: add logic to find urdfdom without pkg-config
cb3bfbc 
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro traversaro force-pushed the search-urdfdom-with-cmake branch from ac620c4 to cb3bfbc Compare September 5, 2020 09:35
@scpeters scpeters merged commit 94055d1 into gazebosim:sdf9 Sep 7, 2020
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Sep 9, 2020
@traversaro @scpeters
SearchForStuff: add logic to find urdfdom without pkg-config (gazebos…
c6faec2 
…im#245)

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@scpeters scpeters mentioned this pull request Sep 9, 2020
Merged
scpeters pushed a commit that referenced this pull request Sep 10, 2020
@traversaro @scpeters
SearchForStuff: add logic to find urdfdom without pkg-config (#245)
8bf7c92 
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@scpeters scpeters mentioned this pull request Sep 14, 2020
Merged
azeey pushed a commit to azeey/sdformat that referenced this pull request Dec 9, 2020
@traversaro @azeey
SearchForStuff: add logic to find urdfdom without pkg-config (gazebos…
2722e42 
…im#245)

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
brawner pushed a commit that referenced this pull request Dec 11, 2020
@traversaro @brawner
SearchForStuff: add logic to find urdfdom without pkg-config (#245)
9c18bf3 
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
brawner pushed a commit that referenced this pull request Jan 9, 2021
@traversaro @brawner
SearchForStuff: add logic to find urdfdom without pkg-config (#245)
8f87a87 
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@traversaro @scpeters @codecov-commenter @azeey @chapulina