Store material file path information #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf8 #349 +/- ##
==========================================
+ Coverage 87.54% 87.56% +0.01%
==========================================
Files 54 54
Lines 7293 7300 +7
==========================================
+ Hits 6385 6392 +7
Misses 908 908
Continue to review full report at Codecov.
|
|
See also: gazebosim/gz-sim#328 |
scpeters
approved these changes
Sep 3, 2020
|
there are just a few cmake warnings that would be fixed by back-porting #328, which I will do in a separate PR |
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Sep 3, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
chapulina
pushed a commit
that referenced
this pull request
Sep 3, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Sep 3, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
scpeters
pushed a commit
that referenced
this pull request
Sep 4, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
traversaro
pushed a commit
to traversaro/sdformat
that referenced
this pull request
Sep 5, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
brawner
pushed a commit
that referenced
this pull request
Dec 11, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
brawner
pushed a commit
that referenced
this pull request
Jan 9, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the file path of material is required to fix gazebosim/gz-sim#286.
This follows the same pattern as
Mesh::FilePath.Signed-off-by: Nate Koenig nate@openrobotics.org