Update build system to allow overriding CXX flags and using clang on Linux #621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Before this,
CMAKE_CXX_FLAGS
were unset by the mainCMakeLists.txt
in https://github.com/ignitionrobotics/sdformat/blob/8fca2f1409fca6e4867178346590b1c628745315/CMakeLists.txt#L164This makes it impossible to pass additional flags at build time, such as the ones needed for building with ASAN. If there's a particular reason I'm not aware of for unsetting
CMAKE_CXX_FLAGS
, I leave it to those with more CMake knowledge to tell me.This PR also updates the logic to add the
-stdlib=libc++
flag only on macOS.Test it
Build with
cmake .. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang- -DCMAKE_CXX_FLAGS="-fsanitize=address"
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge