Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebosim/gz-sensors#9
Summary
Creating custom sensors that aren't officially part of the spec shouldn't be disallowed. This PR provides a simple way for users to tell SDF that they're loading a custom sensor, so it's not an error if SDF doesn't recognize the sensor type. Note that this is different from a sensor with
NONE
type, which is an error.Users are encouraged to use Custom SDF Elements to pass configuration to their custom sensors, like the
ignition:custom_sensor
element below:This is an initial proposal, I'm open to other ideas for supporting custom sensors.
Test it
I'm making use of this on these WIP PRs, you can try them out:
Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸