Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add missing //plugin to //include #668

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

FirefoxMetzger
Copy link
Contributor

🦟 Bug fix

Partially addresses #641 . It adds the missing element, but doesn't do anything about additional namespaced elements.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use *Squash-Merge

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 12, 2021
@chapulina chapulina requested a review from azeey August 23, 2021 18:46
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Would you mind also creating a PR for the sdf9 branch?

@FirefoxMetzger
Copy link
Contributor Author

@azeey Done. There does not seem to be a v1.8 folder on sdf9, so I only applied the changes to v1.7 and below.

@azeey azeey merged commit 330e62d into gazebosim:sdf11 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants