-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codecov badge url #678
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #678 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 62 62
Lines 9734 9734
=======================================
Hits 8453 8453
Misses 1281 1281 Continue to review full report at Codecov.
|
@@ -17,7 +17,7 @@ allows conversion from previous versions. | |||
|
|||
Test coverage: | |||
|
|||
[![codecov](https://codecov.io/bb/ignitionrobotics/sdformat/branch/default/graph/badge.svg)](https://codecov.io/bb/ignitionrobotics/sdformat) | |||
[![codecov](https://codecov.io/gh/ignitionrobotics/sdformat/branch/sdf9/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/sdformat/branch/sdf9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this is forward ported will the branch need to be changed (e.g.,sdf9
-> sdf10
)? If so, should we add a comment above this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. b1a9b9a
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
🦟 Bug fix
Summary
The badge was incorrectly pointing to the codecov account associated with the bitbucket repo. This updates it to use a github link and also updates the branch so that each release branch has a README that points to a codecov badge associated with the branch.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge