Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov badge url #678

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Update codecov badge url #678

merged 3 commits into from
Aug 27, 2021

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Aug 26, 2021

🦟 Bug fix

Summary

The badge was incorrectly pointing to the codecov account associated with the bitbucket repo. This updates it to use a github link and also updates the branch so that each release branch has a README that points to a codecov badge associated with the branch.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Aug 26, 2021
@azeey azeey self-assigned this Aug 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #678 (aa1419a) into sdf9 (aab1512) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf9     #678   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          62       62           
  Lines        9734     9734           
=======================================
  Hits         8453     8453           
  Misses       1281     1281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab1512...aa1419a. Read the comment docs.

@azeey azeey requested a review from jennuine August 26, 2021 21:14
@@ -17,7 +17,7 @@ allows conversion from previous versions.

Test coverage:

[![codecov](https://codecov.io/bb/ignitionrobotics/sdformat/branch/default/graph/badge.svg)](https://codecov.io/bb/ignitionrobotics/sdformat)
[![codecov](https://codecov.io/gh/ignitionrobotics/sdformat/branch/sdf9/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/sdformat/branch/sdf9)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is forward ported will the branch need to be changed (e.g.,sdf9 -> sdf10)? If so, should we add a comment above this line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. b1a9b9a

azeey added 2 commits August 26, 2021 16:29
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit e18682d into gazebosim:sdf9 Aug 27, 2021
@azeey azeey deleted the codecov_badge branch August 27, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants