Run cpplint/cppcheck on Focal CI #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #880 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 96 96
Lines 14547 14547
=======================================
Hits 12827 12827
Misses 1720 1720
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Mar 15, 2022
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
This is a partial backport of #878 to
sdf12Summary
In #878, the GitHub Actions CI was stopped from testing on Ubuntu Bionic on the
mainbranch. As part of that change, thecppcheckandcpplintchecks were moved to Ubuntu Focal CI. I noticed that there were some pre-existing errors in theusdcomponent, which I believe are not checked on Ubuntu Bionic since theusdcomponent is not tested on that workflow. In order to catch these errors, I've backported this portion of #878 and fixed any other listing errors that were reported.Test it
Run
make codecheckon Ubuntu 20.04 or run the GitHub actions workflow on Ubuntu FocalChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.