Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker/consumer: add CreateRevision to ListResponse #361

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jgraettinger
Copy link
Contributor

@jgraettinger jgraettinger commented Jan 29, 2024

CreateRevision is the revision at which the JournalSpec or ShardSpec was created within Etcd, and pairs with the ModRevision which is already surfaced in the API response.


This change is Reviewable

CreateRevision is the revision at which the JournalSpec or ShardSpec was
created within Etcd, and pairs with the ModRevision which is already
surfaced in the API response.
@jgraettinger jgraettinger requested a review from psFried January 29, 2024 17:29
Copy link
Contributor

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgraettinger jgraettinger merged commit 58d1084 into master Jan 30, 2024
1 check passed
@jgraettinger jgraettinger deleted the johnny/create-revision branch January 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants