Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker/fragment: region support for s3 stores #365

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

williamhbaker
Copy link
Contributor

@williamhbaker williamhbaker commented Mar 8, 2024

Previously s3 stores could only use the region available via a given profile or the AWS application default credentials. This adds the ability to set an alternate region in the endpoint URL for an s3 fragment store for buckets that are in a different region.


This change is Reviewable

Previously s3 stores could only use the region available via a given profile or the AWS application
default credentials. This adds the ability to set an alternate region in the endpoint URL for an s3
fragment store for buckets that are in a different region.
Copy link
Contributor

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit 188c28b into master Mar 11, 2024
1 check passed
@williamhbaker williamhbaker deleted the wb/s3-regions branch March 11, 2024 12:51
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 11, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
williamhbaker added a commit to estuary/flow that referenced this pull request Mar 14, 2024
Allows setting the region for S3 storage mappings, for buckets that are not in the us-east-1 region.

See also: gazette/core#365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants