Phil/colons in names #386
Merged
Phil/colons in names #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the colon (:) character permissible in journal names and label values (but not shard ids, yet). There's valid use cases for allowing them (colons are used as separators in the ids for Flow and other systems), and we've found no reason to disallow them.
Updates consumer shard ID validation to permit a few additional symbols, and bring the set of allowable characters in line with journal names. The characters "=%:" were previously disallowed in shard IDs, but allowed in journal names and label values. Those characters are now permissible in shard IDs too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates protocol validations to permit colons (
:) in journal names, shard ids, and label values. Also updates shard id validation to permit the same characters as for journal names, meaning that= % :are all now allowed in shard ids.This change is