truncate large balances #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
jsign
approved these changes
Oct 31, 2024
|
As noted in dms, panicking would break devmode. So I'm merging this, and taking a note to modify the devmode in master so that it doesn't break. |
gballet
commented
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large balances (>16 bytes) will overwrite the nonce in the basic data leaf. While this can not happen on mainnet, owing to the amount issued, it happens in devmode. This means the nonce will be overwritten with the balance, which is incorrect.
This PR truncates the balance if it's above that threshold.