Fix __FILE__ when filename contains quotes

gbdev · Sep 10, 2020 · 34c2288 · 34c2288
1 parent 304bb9f
commit 34c2288
Showing 1 changed file with 20 additions and 1 deletion.
diff --git a/src/asm/fstack.c b/src/asm/fstack.c
@@ -522,7 +522,26 @@ void fstk_Init(char *pFileName)
 {
 	char tzSymFileName[_MAX_PATH + 1 + 2];
 
-	snprintf(tzSymFileName, sizeof(tzSymFileName), "\"%s\"", pFileName);
+	char *c = pFileName;
+	int fileNameIndex = 0;
+
+	tzSymFileName[fileNameIndex++] = '"';
+
+	// minus 2 to account for trailing "\"\0"
+	// minus 1 to avoid a buffer overflow in extreme cases
+	while (*c && fileNameIndex < sizeof(tzSymFileName) - 2 - 1) {
+
+		if (*c == '"') {
+			tzSymFileName[fileNameIndex++] = '\\';
+		}
+
+		tzSymFileName[fileNameIndex++] = *c;
+		++c;
+	}
+
+	tzSymFileName[fileNameIndex++] = '"';
+	tzSymFileName[fileNameIndex]   = '\0';
+
 	sym_AddString("__FILE__", tzSymFileName);
 
 	pFileStack = NULL;