-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__FILE__ breaks if filename contains a quote #546
Comments
I added a regression test that'll ensure that the new lexer will have to implement it. |
That's great, and that's why we need more tests. With enough coverage it becomes far less scary to make big changes... |
There is however one unintended consequence of adding this test: Windows is not feeling too great about it due to... the quote. I'm not sure how to solve this... |
I think that we shouldn't have that test, probably. I mean, we should have the test, but the file could be generated by the test scripts, and it could be skipped on Windows. Having weird file names is a bad idea. |
Well, I tried generating the test from within the test script, and it somehow still gets generated. How? Beats me. Guess it should only be generated when not on Windows, but how is that detectable reliably? I tried |
Oh, of course, you need to skip the test on Windows. I think that using uname and checking for MinGW is fine, actually. We can always add other strings if needed in the future. |
Fixed it in 9742fa7, then. |
That's about it. The quote(s) need(s) to be escaped.
The text was updated successfully, but these errors were encountered: