Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make && and || short-circuiting #619

Open
ISSOtm opened this issue Dec 9, 2020 · 0 comments
Open

Make && and || short-circuiting #619

ISSOtm opened this issue Dec 9, 2020 · 0 comments
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM rgblink This affects RGBLINK

Comments

@ISSOtm
Copy link
Member

ISSOtm commented Dec 9, 2020

This would require a significant rewrite of the expression system (so that it wouldn't eagerly evaluate everything).

@ISSOtm ISSOtm added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM rgblink This affects RGBLINK labels Dec 9, 2020
@ISSOtm ISSOtm added this to the v0.4.3 milestone Dec 9, 2020
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Dec 26, 2020
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Dec 26, 2020
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Dec 29, 2020
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Dec 30, 2020
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Dec 30, 2020
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 1, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 2, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 2, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 2, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 2, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 2, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 3, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 4, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 6, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 8, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 9, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 9, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 15, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 16, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 17, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 19, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Jan 20, 2021
`true || X` short-circuits to 1 without evaluating X
`false && X` short-circuits to 0 without evaluating X

Fixes gbdev#619
@Rangi42 Rangi42 modified the milestones: v0.5.0, v1.0.0 Feb 28, 2021
@ISSOtm ISSOtm modified the milestones: v1.0.0, v0.5.1 Mar 5, 2021
@Rangi42 Rangi42 modified the milestones: v0.5.1, v0.6.0 Apr 25, 2021
@Rangi42 Rangi42 removed this from the v0.10.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM rgblink This affects RGBLINK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants