Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download libpng source from GitHub, not SourceForge #1223

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Download libpng source from GitHub, not SourceForge #1223

merged 1 commit into from
Nov 7, 2023

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Nov 7, 2023

Fixes #1202

@Rangi42 Rangi42 added the meta This isn't related to the tools directly: repo organization, maintainership... label Nov 7, 2023
@Rangi42 Rangi42 requested a review from ISSOtm November 7, 2023 00:43
ISSOtm
ISSOtm approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, the underlying problem is IMO that we're applying the cache after the downloads, when we should be doing so before... but, ah well.

@ISSOtm ISSOtm merged commit a28f32a into gbdev:master Nov 7, 2023
@Rangi42
Copy link
Contributor Author

Rangi42 commented Nov 7, 2023 •
edited
Loading

Though, the underlying problem is IMO that we're applying the cache after the downloads, when we should be doing so before... but, ah well.

@ISSOtm Can you file an issue for this? Or a PR?

@Rangi42 Rangi42 deleted the libpng-zip branch November 7, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
meta This isn't related to the tools directly: repo organization, maintainership...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download libpng source for Windows from a more reliable site
2 participants
@Rangi42 @ISSOtm